Do not start elemental-register timer manually #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting the service manually prevent proper ordering and tracking of related services. Having a manual start makes it difficult form other services to check its status as there is no obvious way order the related executions. Signed-off-by: David Cassany <[email protected]>
|
Also requires https://build.opensuse.org/request/show/1161712 |
davidcassany
commented
Mar 26, 2024
| @@ -1,6 +1,9 @@ | |||
| [Unit] | |||
| Description=Run elemental-register every 30 minutes | |||
| Documentation=https://elemental.docs.rancher.com | |||
| # Do not run the timer for installation media or recovery system | |||
| ConditionPathExists=!/run/elemental/live_mode | |||
| ConditionPathExists=!/run/elemental/recovery_mode | |||
There was a problem hiding this comment.
These conditions match with the conditions that were added to the manual start within the deleted file.
frelon
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the service manually prevent proper ordering and tracking of related services. Having a manual start makes it difficult form other services to check its status as there is no obvious way order the related executions.
Follow up for #1263