Allow upgrades from an extracted folder #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darren Shepherd <[email protected]>
|
👍 we have to merge this one with the additional tests provided in #264 |
|
@mudler I had no idea you were already merging all the stuff from my repo. Do you even need this PR? Should I close it? |
Yup no worries, I'll take care of merging this one with my branch 👍 |
frelon
pushed a commit
to frelon/elemental-toolkit
that referenced
this pull request
May 12, 2023
Signed-off-by: GitHub <[email protected]> Co-authored-by: davidcassany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows upgrades to happen from an extracted folder which allow a simple approach to upgrade using github.com/rancher/system-upgrade-controller/.
Also notice I change the rsync args. I ran into issue with using AX in a container, but I kind of prefer we don't rely on ACLs and xattrs to be preserved. Are ACLs and xattrs part of the OCI spec? I would think those attributes can't be relies on being the tars from a docker image.