Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v1.1.x] Do not return error for efi.ReadLoadOption #2093

Merged
merged 3 commits into from
May 28, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented May 27, 2024

When encountering a boot-entry for a device-path that go-efilib is
unable to parse we should just skip that entry instead of erroring out.

Backporting this manually and minimally since cherry-picking 2e56a09
had conflicts.

Signed-off-by: Fredrik Lönnegren [email protected]

When encountering a boot-entry for a device-path that go-efilib is
unable to parse we should just skip that entry instead of erroring out.

Backporting this manually and minimally since cherry-picking 2e56a09
had conflicts.

Signed-off-by: Fredrik Lönnegren <[email protected]>
@frelon frelon requested a review from a team as a code owner May 27, 2024 07:17
@frelon frelon changed the title Do not return error for efi.ReadLoadOption [Backport v1.1.x] Do not return error for efi.ReadLoadOption May 27, 2024
Getting the following error in workflow: 'Error: qemu not installed'

Signed-off-by: Fredrik Lönnegren <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Please upload report for BASE (v1.1.x@c20fa28). Learn more about missing BASE report.

Files Patch % Lines
pkg/efi/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.1.x    #2093   +/-   ##
=========================================
  Coverage          ?   75.34%           
=========================================
  Files             ?       67           
  Lines             ?     6814           
  Branches          ?        0           
=========================================
  Hits              ?     5134           
  Misses            ?     1310           
  Partials          ?      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fredrik Lönnegren <[email protected]>
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frelon frelon merged commit e9f70ce into rancher:v1.1.x May 28, 2024
11 checks passed
@frelon frelon deleted the backport-efivar-fix branch May 28, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants