-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default root password #2055
Conversation
@@ -137,9 +137,9 @@ func (s *SUT) ChangeBoot(b string) error { | |||
|
|||
switch b { | |||
case Active: | |||
bootEntry = Cos | |||
bootEntry = "active" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just addressing some old leftovers
case Passive: | ||
bootEntry = "fallback" | ||
bootEntry = "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, just addressing some old leftovers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -14,4 +14,4 @@ stages: | |||
entity: | | |||
kind: "shadow" | |||
username: "root" | |||
password: "cos" | |||
password: "elemental" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
a32b28c
to
2417dcb
Compare
OK, just realized this requires some more love, if the password changes across versions the test suite will also fail. I think the proper solution is once an for all setting the authorized ssh keys as part of the cloud config in tests, this way we could eventually connect without needing a password at all. |
9490b7b
to
44bca09
Compare
Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
Signed-off-by: David Cassany <[email protected]>
44bca09
to
c11c096
Compare
@@ -13,7 +13,7 @@ endif | |||
|
|||
.PHONY: test-active | |||
test-active: prepare-test | |||
VM_PID=$$(scripts/run_vm.sh vmpid) go run $(GINKGO) $(GINKGO_ARGS) ./tests/wait-active | |||
VM_PID=$$(scripts/run_vm.sh vmpid) COS_PASS=cos go run $(GINKGO) $(GINKGO_ARGS) ./tests/wait-active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade test requires the legacy password because it boots with an older disk, so the password needs to be added for test-active
and test-upgrade
. It always tries to login by the authorized key first and if not it fallbacks to the password method.
I could not find an easy way at ssh package level to set multiple passwords to try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
No description provided.