Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over passive snapshots on boot-assessment #2027

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

davidcassany
Copy link
Contributor

This commit prevents falling back to recovery system during the boot assessment process.

@davidcassany davidcassany requested a review from a team as a code owner March 25, 2024 07:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.36%. Comparing base (24e2c8f) to head (8fb0e52).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2027   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files          76       76           
  Lines        9009     9010    +1     
=======================================
+ Hits         6519     6520    +1     
  Misses       1946     1946           
  Partials      544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frelon
frelon previously approved these changes Mar 25, 2024
@davidcassany davidcassany force-pushed the improve_boot_assessment branch 2 times, most recently from 8fb0e52 to 291ab0d Compare March 25, 2024 12:13
This commit prevents falling back to recovery system during the boot
assessment process.

In addition it also sets the boot_assessment to be executed on install
and reset reboots.

Signed-off-by: David Cassany <[email protected]>
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit 1a6026e into rancher:main Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants