Add loopdevice implementation #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
add_loopdevice_implementation
branch
from
71447be
to
582cefa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
==========================================
+ Coverage 73.53% 73.68% +0.14%
==========================================
Files 70 71 +1
Lines 7391 7747 +356
==========================================
+ Hits 5435 5708 +273
- Misses 1558 1618 +60
- Partials 398 421 +23 ☔ View full report in Codecov by Sentry. |
Signed-off-by: David Cassany <[email protected]>
davidcassany
force-pushed
the
add_loopdevice_implementation
branch
from
582cefa
to
ac6d170
Compare
frelon
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the LoopDevice implementation and applies few little changes in utilities to make ResolveLink method easier to use.
This LoopDevice implementation includes its unit tests but it is no used anywhere yet, meaning it does not changes the flow of any already existing elemental command. In a follow up PR there will be a refactor on install, reset and upgrade commands to actually make use of it.
Part of #1874