Fix initrd and kernel ISO paths #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <[email protected]>
frelon
approved these changes
Dec 1, 2023
davidcassany
commented
Dec 1, 2023
| @@ -313,10 +313,10 @@ func ISOLoaderPath(arch string) string { | |||
|
|
|||
| // ISOKernelPath returns path use to store the kernel | |||
| func ISOKernelPath(arch string) string { | |||
| return ISOLoaderPath(arch) + "linux" | |||
| return filepath.Join(ISOLoaderPath(arch), "linux") | |||
There was a problem hiding this comment.
@ldevulder note the arch is passed as an argument instead of using runtime architecture to enable cross arch builds. We might be looking to build arm64 images in a x86_64 host, I think we are so close to make that possible.
ldevulder
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the kernel path from
/boot/<arch>/loaderlinuxto/boot/<arch>/loader/linux. An equivalent change is applied on initrd path.