Add teal flavor #1259
Add teal flavor #1259
Conversation
mudler
force-pushed
the
teal
branch
11 times, most recently
from
1083d15
to
d3d36c9
Compare
mudler
added
status/safe to test
mudler
force-pushed
the
teal
branch
3 times, most recently
from
b20d7a1
to
75e8e3e
Compare
Add teal flavor to our pipelines. Part of #1238 Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Teal don't have any online repos where we can install packages from Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
removed
status/safe to test
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
|
Most of this is just adding new pipelines, so it comes with a lot of additions. On a package-tree related changes it does the following:
|
|
I'd go ahead with this and check out manually the artifacts to see if there are any issues and will double check with the ones we currently have for green, I bet there will be some small adjustments to do |
| @@ -3,6 +3,16 @@ requires: | |||
| category: "distro" | |||
| version: ">=0" | |||
|
|
|||
| excludes: | |||
| - ^/boot/grub2 | |||
There was a problem hiding this comment.
I think those two previously just slipped in, no real need to add them as part of the kernel package
| upx bin/rancherd && \ | ||
| cp bin/rancherd /usr/bin/ | ||
| ./scripts/build | ||
| {{ if .Values.upx }} |
There was a problem hiding this comment.
as a low hanging fruit, I think upx should be moved as a global value and make all golang binary optionally spit upx'ed bins. In this way we can see if we can reduce binary sizes. I remind #356 hitting because of upx, but we never experimented with lower compression ratios.
| if err != nil { | ||
| panic(err) | ||
| fmt.Println("No packages found") |
There was a problem hiding this comment.
If we don't find any package (because the repo is new) we previously panic'ed. I think we did this as a safeguard mechanism, but in any case we do repo snapshotting now, so we shouldn't care much.
| @@ -7,16 +7,9 @@ package_dir: /{{.Values.name}} | |||
|
|
|||
| env: | |||
| - PATH=$PATH:/usr/local/go/bin | |||
| - CGO_ENABLED=0 | |||
There was a problem hiding this comment.
somehow those slipped in 🤷♂️ I added those back as teal was failing trying to run ld, so I noticed that we were building with cgo on. I'm pretty sure we didn't do that on purpose, we used to disable this only on fips builds
| {{if eq .Values.codename "teal" }} | ||
| unpack: true | ||
| includes: | ||
| - ^/boot|^/boot/.* |
There was a problem hiding this comment.
The real difference in teal is that we extract all the kernels from the image, so no zypper in or build happening
| @@ -1,4 +1,6 @@ | |||
| {{ define "distro_install" }} | |||
| ## All packages for teal are in the teal image already. | |||
| {{ if ne .Values.codename "teal" }} | |||
There was a problem hiding this comment.
This is gating accidental calls to zypper in.. if we are in teal. supposedly, we don't add any repo to it
Add teal flavor to our pipelines.
Part of #1238
Signed-off-by: Ettore Di Giacinto [email protected]