-
Notifications
You must be signed in to change notification settings - Fork 715
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1131 from aiyengar2/fix_crd_chart Fix CRD chart regression and fix CRDs for upgrades
- Loading branch information
1 parent
98aacb0
commit 3a740f9
Showing
49 changed files
with
561 additions
and
5,367 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
released/assets/rancher-alerting-drivers/rancher-alerting-drivers-1.0.100.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-backup-crd/rancher-backup-crd-1.0.400.tgz
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-5 Bytes
(100%)
released/assets/rancher-cis-benchmark/rancher-cis-benchmark-1.0.400.tgz
Binary file not shown.
Binary file modified
BIN
-5 Bytes
(100%)
released/assets/rancher-cis-benchmark/rancher-cis-benchmark-1.0.402.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-cis-benchmark/rancher-cis-benchmark-crd-1.0.400.tgz
Binary file not shown.
Binary file modified
BIN
-2 Bytes
(100%)
released/assets/rancher-cis-benchmark/rancher-cis-benchmark-crd-1.0.402.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-gatekeeper/rancher-gatekeeper-3.3.001.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-gatekeeper/rancher-gatekeeper-crd-3.3.001.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-grafana/rancher-grafana-6.6.401.tgz
Binary file not shown.
Binary file modified
BIN
-295 Bytes
(98%)
released/assets/rancher-istio-1.8/rancher-istio-1.8.301.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+2 Bytes
(100%)
released/assets/rancher-istio-1.9/rancher-istio-1.9.200.tgz
Binary file not shown.
Binary file modified
BIN
+2 Bytes
(100%)
released/assets/rancher-istio-1.9/rancher-istio-1.9.300.tgz
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
released/assets/rancher-kiali-server/rancher-kiali-server-1.29.100.tgz
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
released/assets/rancher-kiali-server/rancher-kiali-server-1.32.100.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-kiali-server/rancher-kiali-server-crd-1.29.100.tgz
Binary file not shown.
Binary file modified
BIN
+2 Bytes
(100%)
released/assets/rancher-kiali-server/rancher-kiali-server-crd-1.32.100.tgz
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
released/assets/rancher-kube-state-metrics/rancher-kube-state-metrics-2.13.101.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-logging/rancher-logging-3.9.001.tgz
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+2 Bytes
(100%)
released/assets/rancher-logging/rancher-logging-3.9.400.tgz
Binary file not shown.
Binary file modified
BIN
+10 Bytes
(100%)
released/assets/rancher-logging/rancher-logging-crd-3.9.001.tgz
Binary file not shown.
Binary file modified
BIN
+10 Bytes
(100%)
released/assets/rancher-logging/rancher-logging-crd-3.9.002.tgz
Binary file not shown.
Binary file modified
BIN
+11 Bytes
(100%)
released/assets/rancher-logging/rancher-logging-crd-3.9.400.tgz
Binary file not shown.
Binary file modified
BIN
+14 KB
(110%)
released/assets/rancher-monitoring/rancher-monitoring-14.5.100.tgz
Binary file not shown.
Binary file modified
BIN
+4.16 KB
(100%)
released/assets/rancher-monitoring/rancher-monitoring-9.4.204.tgz
Binary file not shown.
Binary file modified
BIN
+972 Bytes
(100%)
released/assets/rancher-monitoring/rancher-monitoring-crd-14.5.100.tgz
Binary file not shown.
Binary file modified
BIN
-3 Bytes
(100%)
released/assets/rancher-monitoring/rancher-monitoring-crd-9.4.204.tgz
Binary file not shown.
Binary file modified
BIN
-6 Bytes
(100%)
released/assets/rancher-node-exporter/rancher-node-exporter-1.16.201.tgz
Binary file not shown.
Binary file modified
BIN
-2 Bytes
(100%)
released/assets/rancher-operator-crd/rancher-operator-crd-0.1.400.tgz
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
released/assets/rancher-operator/rancher-operator-0.1.400.tgz
Binary file not shown.
Binary file modified
BIN
+1 Byte
(100%)
released/assets/rancher-prom2teams/rancher-prom2teams-0.2.000.tgz
Binary file not shown.
Binary file modified
BIN
+2 Bytes
(100%)
released/assets/rancher-prometheus-adapter/rancher-prometheus-adapter-2.12.101.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-pushprox/rancher-pushprox-0.1.300.tgz
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
released/assets/rancher-tracing/rancher-tracing-1.20.100.tgz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
released/assets/rancher-webhook/rancher-webhook-0.1.000.tgz
Binary file not shown.
Binary file modified
BIN
+1 Byte
(100%)
released/assets/rancher-windows-exporter/rancher-windows-exporter-0.1.000.tgz
Binary file not shown.
Binary file modified
BIN
-2 Bytes
(100%)
released/assets/rancher-wins-upgrader/rancher-wins-upgrader-0.0.100.tgz
Binary file not shown.
22 changes: 22 additions & 0 deletions
22
released/charts/rancher-monitoring/rancher-monitoring-crd/14.5.100/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,24 @@ | ||
# rancher-monitoring-crd | ||
A Rancher chart that installs the CRDs used by rancher-monitoring. | ||
|
||
## How does this chart work? | ||
|
||
This chart marshalls all of the CRD files placed in the `crd-manifest` directory into a ConfigMap that is installed onto a cluster alongside relevant RBAC (ServiceAccount, ClusterRoleBinding, ClusterRole, and PodSecurityPolicy). | ||
|
||
Once the relevant dependent resourcees are installed / upgraded / rolled back, this chart executes a post-install / post-upgrade / post-rollback Job that: | ||
- Patches any existing versions of the CRDs contained within the `crd-manifest` on the cluster to set `spec.preserveUnknownFields=false`; this step is required since, based on [Kubernetes docs](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#field-pruning) and a [known workaround](https://github.com/kubernetes-sigs/controller-tools/issues/476#issuecomment-691519936), such CRDs cannot be upgraded normally from `apiextensions.k8s.io/v1beta1` to `apiextensions.k8s.io/v1`. | ||
- Runs a `kubectl apply` on the CRDs that are contained within the crd-manifest ConfigMap to upgrade CRDs in the cluster | ||
|
||
On an uninstall, this chart executes a separate post-delete Job that: | ||
- Patches any existing versions of the CRDs contained within `crd-manifest` on the cluster to set `metadata.finalizers=[]` | ||
- Runs a `kubectl delete` on the CRDs that are contained within the crd-manifest ConfigMap to clean up the CRDs from the cluster | ||
|
||
Note: If the relevant CRDs already existed in the cluster at the time of install, this chart will absorb ownership of the lifecycle of those CRDs; therefore, on a `helm uninstall`, those CRDs will also be removed from the cluster alongside this chart. | ||
|
||
## Why can't we just place the CRDs in the templates/ directory of the main chart? | ||
|
||
In Helm today, you cannot declare a CRD and declare a resource of that CRD's kind in templates/ without encountering a failure on render. | ||
|
||
## [Helm 3] Why can't we just place the CRDs in the crds/ directory of the main chart? | ||
|
||
The Helm 3 `crds/` directory only supports the installation of CRDs, but does not support the upgrade and removal of CRDs, unlike what this chart facilitiates. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.