Replace empty list with empty pd.Series #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated the description. Please review. |
ValueRaider
requested changes
Jan 8, 2024
requirements.txt
Outdated
Comment on lines
3
to
13
| requests_cache==1.1.0 | ||
| requests_ratelimiter==0.4.2 | ||
| multitasking>=0.0.7 | ||
| lxml>=4.9.1 | ||
| appdirs>=1.4.4 | ||
| pytz>=2022.5 | ||
| frozendict>=2.3.4 | ||
| beautifulsoup4>=4.11.1 | ||
| html5lib>=1.1 | ||
| peewee>=3.16.2 No newline at end of file | ||
| peewee>=3.16.2 |
There was a problem hiding this comment.
I reverted the explicit dependencies but kept the newline at the end.
tests/ticker.py
Outdated
| @@ -798,7 +814,7 @@ def test_info(self): | |||
| def suite(): | |||
| suite = unittest.TestSuite() | |||
| suite.addTest(TestTicker('Test ticker')) | |||
| suite.addTest(TestTickerEarnings('Test earnings')) | |||
| #suite.addTest(TestTickerEarnings('Test earnings')) | |||
There was a problem hiding this comment.
I branched from the wrong base I guess. Reverted.
|
You might have a better time with Git if you rebase your changes. |
I don't get what happend acutally. I rebased from master to dev and git messed something up. This is the second branch already. I usually don't use rebase because of these issues. Anyway, is there something you request a change for? |
|
I'll merge this time, but in future:
|
Alright |
ValueRaider
approved these changes
Jan 9, 2024
Merged
ValueRaider
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug, when you want to perform a pandas operation on an empty list, which is returned when no data is present:
This change does 2 things: