fix(hermes): address igorls' second review pass on PR #1915 - #2
Closed
GoXLd wants to merge 1 commit into
Closed
Conversation
- on_session_end() no longer re-mines turns sync_turn() already filed live; make_exchange_drawer_id includes filed_at so replays were becoming duplicate drawers, not idempotent rewrites. Delegation turns (on_delegation) are excluded from the skip count since they don't appear in the transcript on_session_end receives. - _dispatch_mcp_passthrough now pins MEMPALACE_PALACE_PATH to the provider's configured palace_path for the call, so passthrough tools (add/update/delete_drawer, tunnels, etc.) can no longer read/write a different palace than mempalace_search/status/list_wings do. - on_memory_write() mirrors target="memory" (Hermes' default when the caller omits target), not just the explicit "user" target. - Added backup_paths() so `hermes backup` picks up MemPalace's actual state, which lives outside HERMES_HOME by default. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
|
Thanks for the contribution, but I am going to remove on_session_end and on_pre_compress mining for now and do a follow up PR to do it properly. I found more things in my investigation that are worth considering |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hermes backuppicks up MemPalace's actual state, which lives outside HERMES_HOME by default.What does this PR do?
How to test
Checklist
python -m pytest tests/ -v)ruff check .)