Cut v1.2.1 rallyhealth#3
Merged
Merged
Conversation
* fix: this close issue argoproj#1963 by adding pagination to FindLoadBalancerByDNSName This adds pagination to the FindLoadBalancerByDNSName function this should allow argo rollouts to work with any number of loadbalancers. Signed-off-by: zachaller <zachaller@hotmail.com>
* fix: turn missing load balancer log into an event Signed-off-by: zachaller <zachaller@hotmail.com> * consistent naming Signed-off-by: zachaller <zachaller@hotmail.com>
…1937) fix: Use actual weight from status field on rollout object (argoproj#1937) Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tperdue321
requested review from
alexolivero,
glenn-engstrand,
htmldoug and
tall-dan
added 2 commits
August 30, 2022 11:40
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=========================================
Coverage ? 82.41%
=========================================
Files ? 120
Lines ? 17484
Branches ? 0
=========================================
Hits ? 14410
Misses ? 2362
Partials ? 712 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 2 commits
August 30, 2022 11:56
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tall-dan
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tagging reviewers for awareness. The latest rallyhealth version of argo-rollouts is v1.2.0 so I'm making a v1.2.1-rallyhealth cut