Remapped the lifetimes of FFISlice and FFISliceMut a bit. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows FFISlice and FFISliceMut to 'leak' a slice of the backing data, even though the returned slice has a valid actual lifetime. This allows FFISlice to be a pass-through through type.
Earthmark
commented
Jun 29, 2024
| fn multi_borrow_mut_slice() { | ||
| let slice = &mut [0, 1, 2, 3, 5]; | ||
| let empty = FFISliceMut::<u8>::empty(); | ||
| let target: &mut [u8] = { |
There was a problem hiding this comment.
Trying to borrow slice again results in a complier error, this is still a safe piece of code because the original slice is the scope of mutation, not the intermediate FFISliceMut.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows FFISlice and FFISliceMut to 'leak' a slice of the backing data, even though the returned slice has a valid actual lifetime.
This allows FFISlice to be a pass-through through type.