Add support for Deneb EIP-4844 types (blobs support)#77
Merged
ralexstokes merged 9 commits intoralexstokes:mainfrom Aug 3, 2023
Merged
Add support for Deneb EIP-4844 types (blobs support)#77ralexstokes merged 9 commits intoralexstokes:mainfrom
ralexstokes merged 9 commits intoralexstokes:mainfrom
Conversation
# Conflicts: # Cargo.lock # Cargo.toml # mev-rs/src/types/mod.rs
Contributor
Author
|
Hey @ralexstokes 👋 |
jimmygchen
changed the title
ralexstokes
reviewed
Aug 2, 2023
Owner
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
thanks for this @jimmygchen !
it may need one more rebase from main but I think it is good enough to merge for now
# Conflicts: # Cargo.lock # Cargo.toml
Contributor
Author
|
Thanks @ralexstokes I'm seeing a test failure locally, looking into it now |
Contributor
Author
|
Turned out it was a local issue, CI is passing locally now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builder spec: ethereum/builder-specs#61
This PR updates the Deneb EIP-4844 types only, logic for supporting blobs are not implemented.