Update BlindedBlobsBundle SSZ and deserialize signed blinded block (Deneb) #124
Merged
ralexstokes merged 7 commits intoralexstokes:mainfrom Sep 12, 2023
Merged
Conversation
jimmygchen
force-pushed
the
deserialize_deneb_block
branch
from
9896666 to
dedc77a
Compare
jimmygchen
commented
Sep 5, 2023
2 tasks
ralexstokes
reviewed
Sep 8, 2023
Owner
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
generally looks great!
have one ask to unify how we handle the clocks
and a question on your decoding strategy
Merged
ralexstokes
approved these changes
Sep 12, 2023
| Err(_) => return Err(ApiClientError::from(err).into()), | ||
| }, | ||
| }; | ||
| let mut block = deneb::SignedBlindedBlockAndBlobSidecars::deserialize(&block) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlindedBlobsBundleSSZ, spec PR here. I've also updatedBlobsBundleto keep it consistent (although it doesn't really matter because they are never signed)handle_open_bidto deserialize Deneb variant ofSignedBlindedBlockAndBlobSidecars. The try-and-fallback approach isn't really ideal, it may be worth considering a v2 endpoint with a mandatoryEth-Consensus-Versionheader (and perhaps SSZ support as well).ethereum-consensusandbeacon-api-clientdependencies to makemev-rswork for latest deneb spec.