Add godoc comments indicating that a mutex is needed for use with goroutines #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase it? I cannot merge due to the conflict. |
…ccess across multiple goroutines
skidder
force-pushed
the
mention-thread-safety-in-godoc
branch
from
b8cc6e3
to
78a3d9b
Compare
|
@rakyll I've rebased my PR branch to incorporate more recent changes |
| // when it is no longer needed. Access to the magicmime | ||
| // database is not synchronized; the magicmime database file-descriptor | ||
| // is referenced through a global variable. Add mutex Lock/Unlock around | ||
| // the magicmime functions if using multiple goroutines. |
There was a problem hiding this comment.
Does that mean we should guard between calls to a specific Decoder's methods? Or between calls to magicmime.NewDecoder() calls? or both?
There was a problem hiding this comment.
Pretty sure that it's only between calls to a specific Decoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.