remove most ptr_fun #277
Merged
remove most ptr_fun #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakshasa
reviewed
Dec 21, 2024
src/protocol/handshake_manager.cc
Outdated
| bool | ||
| HandshakeManager::find(const rak::socket_address& sa) { | ||
| return std::find_if(base_type::begin(), base_type::end(), std::bind1st(handshake_manager_equal(), &sa)) != base_type::end(); | ||
| auto f = [&sa](const Handshake* p2) { return p2->peer_info() && sa == *rak::socket_address::cast_from(p2->peer_info()->socket_address()); }; | ||
| return std::any_of(base_type::begin(), base_type::end(), f); |
There was a problem hiding this comment.
Wrong style, should not use an intermediate function variable.
There was a problem hiding this comment.
It’s pretty long though
There was a problem hiding this comment.
It should be multiple lines, and is what I find to be the best style for these cases.
There was a problem hiding this comment.
Done. clang-format seems happy.
rakshasa
reviewed
Dec 21, 2024
src/protocol/handshake_manager.cc
Outdated
| @@ -77,7 +72,7 @@ HandshakeManager::erase_download(DownloadMain* info) { | |||
| return info != h->download(); | |||
| }); | |||
|
|
|||
| std::for_each(split, base_type::end(), std::ptr_fun(&handshake_manager_delete_handshake)); | |||
| std::for_each(split, base_type::end(), &handshake_manager_delete_handshake); | |||
Removed in C++17 Signed-off-by: Rosen Penev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in C++17