Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few issues #54

Merged
merged 2 commits into from
Oct 8, 2015
Merged

Conversation

Flati
Copy link

@Flati Flati commented Oct 7, 2015

Removed console.log command.
Fixed error when decreasing hours and minutes to 0. (24-hour format) Issue #48
Changed implementation of increasing and decreasing hours. (24-hour format)
When inputEpochTime is not initialized, using current time. Issue #53
Fixed an issue when inputEpochTime was set to 0. It used to use the last known inputEpochTime. Now actually uses 00:00 (midnight).

Flati added 2 commits October 7, 2015 10:20
…sue with step when going past the hour point (going from 55 to 05 with step 10 is now possible, does not force 0). Fixed an issue when inputEpoch was set to 0, now using 0 instead of last known value.
@rajeshwarpatlolla
Copy link
Owner

Thank you so much @Flati. I will take a look at it and will merge your PR. Thanks again.

@Flati
Copy link
Author

Flati commented Oct 7, 2015

I relized I forgot to mention 1 change in the comment above.
When step is set to something other than 1, and a step will take the minutes past 60 (or 0), it will be correctly calculated instead of forcing it to 0.
E.g. 55 minutes, step = 10. Pressing "up" will now take you to 05 minutes instead of 00 minutes.
Same goes for 05 minutes and pressing "down" will now take you to 55 minutes instead of 00 minutes.

@rajeshwarpatlolla rajeshwarpatlolla merged commit aaf1c8b into rajeshwarpatlolla:master Oct 8, 2015
@rajeshwarpatlolla
Copy link
Owner

Thank you so much for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants