Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive page size and hint how to quit #1476

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

edlerd
Copy link
Contributor

@edlerd edlerd commented Nov 12, 2024

Done

Copy link
Owner

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

The dynamic page size looks good.

Thank you for the suggestion for the interactive mode help, although I think in this case I would like to keep the instructions minimal and not have to print something that should be fairly obvious to most people. Interactive mode can be cancelled with Escape or Ctrl + C which are both highly conventional, and per #1414 I would be open to the addition of q to quit. Again just a personal preference to keep the instructions as terse as possible.

@raineorshine raineorshine merged commit 3027213 into raineorshine:main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants