semver-utils isn't exported

[regseb]

• I have searched for similar issues

semver-utils is imported in build/index.d.ts. But the library semver-utils isn't in the package.json dependencies.

---

Steps to Reproduce

Files:

• package.json

  {
      "name": "testcase",
      "version": "1.0.0",
      "type": "module",
      "dependencies": {
          "npm-check-updates": "17.1.3",
          "typescript": "5.6.2"
      }
  }

• index.ts

  import ncu from "npm-check-updates";
  
  console.log(await ncu.run());

Steps:

1. npm install
2. npx tsc --module nodenext index.ts

Current Behavior

node_modules/npm-check-updates/build/index.d.ts:1:24 - error TS2307: Cannot find module 'semver-utils' or its corresponding type declarations.

1 import { SemVer } from 'semver-utils';
                         ~~~~~~~~~~~~~~


Found 1 error in node_modules/npm-check-updates/build/index.d.ts:1

Expected Behavior

No error.

[raineorshine]

Hi, thanks for reporting.

semver-utils is included in the package.json, but maybe Rollup is not bundling it properly. Do you know how to force Rollup to include a library?

[regseb]

semver-utils is in the "devDependencies" that aren't published. It should be put in "dependencies".

[raineorshine]

Vite uses Rollup to automatically tree shake the devDependencies and bundle them for production.

https://github.com/raineorshine/npm-check-updates/blob/main/vite.config.mts

[raineorshine]

I'm sure it's just a matter of adding it to the Vite config. I'll play around with it next chance I get :).

[regseb]

The problem occurred with version 17.0.0. There is no error with version 16.14.20.

I think Vite / Rollup don't handle bundles of .d.ts files very well. If the semver-utils source code is bundled in the index.js file. The types of semver-utils should also be bundled in the index.d.ts file.

[raineorshine]

I have added @types/semver-utils to the tsconfig paths. Can you try it with npm install [email protected]?

diff --git a/tsconfig.json b/tsconfig.json
index 0d900ee3..7ce5b455 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -15,6 +15,7 @@
     "noImplicitAny": true,
     "paths": {
       "libnpmconfig": ["./src/types/libnpmconfig"],
+      "@types/semver-utils": ["./node_modules/@types/semver-utils"],
       "prompts-ncu": ["./src/types/prompts-ncu"]
     },
     "resolveJsonModule": true,

Reference: https://github.com/qmhc/vite-plugin-dts#type-errors-that-are-unable-to-infer-types-from-packages-in-node_modules

[regseb]

I still have the same error. The import of semver-utils is still in the index.d.ts file.

I think your configuration change doesn't fix the problem, because you define a path for @types/semver-utils, but it's semver-utils that gets imported.

[raineorshine]

Hmmm okay. I'll try to think of something else 🤔

[raineorshine]

I have limited time right now, so it would be great if somebody could jump in and investigate this further! 🙏