fix: fetchPartialPackument fallback is not done right (#1446)

raineorshine · Aug 7, 2024 · 71423af · 71423af
1 parent cf94481
commit 71423af
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/package-managers/npm.ts b/src/package-managers/npm.ts
@@ -117,7 +117,7 @@ const fetchPartialPackument = async (
     }
 
     // possible that corgis are not supported by this registry
-    return fetchPartialPackument(name, fields, tag, { opts, fullMetadata: true })
+    return fetchPartialPackument(name, fields, tag, { ...opts, fullMetadata: true }, version)
   }
 }
 

diff --git a/test/getEnginesNodeFromRegistry.test.ts b/test/getEnginesNodeFromRegistry.test.ts
@@ -15,7 +15,7 @@ describe('getEnginesNodeFromRegistry', function () {
 
   it('single package empty', async () => {
     await chalkInit()
-    const data = await getEnginesNodeFromRegistry({ 'ncu-test-return-version': '1.0' }, {})
+    const data = await getEnginesNodeFromRegistry({ 'ncu-test-return-version': '1.0.0' }, {})
     data.should.deep.equal({ 'ncu-test-return-version': undefined })
   })
 

diff --git a/test/package-managers/npm/index.test.ts b/test/package-managers/npm/index.test.ts
@@ -34,6 +34,9 @@ describe('npm', function () {
 
   it('getEngines', async () => {
     await npm.getEngines('del', '2.0.0').should.eventually.deep.equal({ node: '>=0.10.0' })
-    await npm.getEngines('ncu-test-return-version', '1.0').should.eventually.deep.equal({})
+    await npm.getEngines('ncu-test-return-version', '1.0.0').should.eventually.deep.equal({})
+    await npm
+      .getEngines('ncu-test-return-version', '1.0')
+      .should.eventually.be.rejectedWith('404 Not Found - GET https://registry.npmjs.org/ncu-test-return-version/1.0')
   })
 })
-Original file line number
+Diff line change
@@ Expand Up / @@ -117,7 +117,7 @@ const fetchPartialPackument = async ( @@
         }
         // possible that corgis are not supported by this registry
-        return fetchPartialPackument(name, fields, tag, { opts, fullMetadata: true })
+        return fetchPartialPackument(name, fields, tag, { ...opts, fullMetadata: true }, version)
       }
     }
@@ Expand Down @@