Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Statement parsing #64

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Fix Statement parsing #64

merged 3 commits into from
Jan 28, 2025

Conversation

bonflintstone
Copy link
Member

  • Fix header stripping regex
  • Better statement separating regex

@janz93 janz93 force-pushed the fix-header-stripping-regex branch from bca9404 to f5a66a7 Compare January 23, 2025 16:16
@janz93
test: load debugger by default
b82270a 
to improve the development experience we load the debugger on the test start to enable debugging automatically
@janz93 janz93 force-pushed the fix-header-stripping-regex branch 2 times, most recently from 80742f4 to c3224f7 Compare January 23, 2025 16:21
@bonflintstone @janz93
Fix header stripping regex
a963e6b 
Making it work on statements without headers (replacing + by *)

Co-authored-by: Jan von Magnus <[email protected]>
@janz93 janz93 force-pushed the fix-header-stripping-regex branch from c3224f7 to 67a4b79 Compare January 23, 2025 16:22
@janz93 janz93 marked this pull request as ready for review January 23, 2025 16:24
bonflintstone
bonflintstone commented Jan 24, 2025
View reviewed changes
Copy link
Member Author

@bonflintstone bonflintstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve since it's my pr. Looks good!

.rspec Show resolved Hide resolved
lib/cmxl.rb Show resolved Hide resolved
spec/statement_spec.rb Show resolved Hide resolved
@bonflintstone @janz93
Better statement separating regex
af2f314 
Split on lines starting with - and being surrounded by at least on
newline before, but arbitrary amounts of newlines before and after.
The dash can be followed by anything (having seen both '}' and 'ä' in
real examples)

Co-authored-by: Jan von Magnus <[email protected]>
@janz93 janz93 force-pushed the fix-header-stripping-regex branch from 8ad1237 to af2f314 Compare January 28, 2025 13:35
@janz93 janz93 merged commit c3ba2e0 into master Jan 28, 2025
5 checks passed
@janz93 janz93 deleted the fix-header-stripping-regex branch January 28, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janz93 janz93 janz93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonflintstone @janz93