Move to a single singleton #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/install/template.rb
Outdated
|
|
||
| puts "Creating javascript app source directory" | ||
| directory "#{__dir__}/javascript", "#{Webpacker::Configuration.source}" | ||
| directory "#{__dir__}/javascript", "app/javascript" |
Member
There was a problem hiding this comment.
If someone re-runs webpacker:install this will re-create app/javascriptif the source path is not the default we ship
Member
Author
There was a problem hiding this comment.
Ah, I see. We can revert that then.
Need a better system for ensuring that the config is kept updated with new keys before we nix it.
This was referenced Aug 30, 2017
3 tasks
yoshdog
pushed a commit
to yoshdog/react-rails
that referenced
this pull request
Sep 11, 2017
Webpack has changed their public API in this PR: rails/webpacker#636 This PR allows `react-rails` to work with the latest webpacker version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a million different singletons all referring to each other was getting too much. Now there’s a single root singleton and just normal classes used through composition instead.