Cache test pack compilation #539
Conversation
|
@gauravtiwari This is brilliant, thank you! :) |
|
@gauravtiwari looks great! ❤️ |
|
Excellent work, thanks @gauravtiwari much appreciated. |
lib/install/config/webpacker.yml
Outdated
| @@ -4,7 +4,8 @@ default: &default | |||
| source_path: app/javascript | |||
| source_entry_path: packs | |||
| public_output_path: packs | |||
| compile_missing_packs: true | |||
|
|
|||
| compile_missing_packs: false | |||
There was a problem hiding this comment.
I wasn't quite clear on the usage and it seemed that the main purpose of this is to compile assets during lookup when running tests. For rest of the cases, either dev server or watcher can be used. By default we turn if off and can be toggled per env. WDYT?
lib/install/config/webpacker.yml
Outdated
| @@ -35,7 +36,13 @@ test: | |||
|
|
|||
| public_output_path: packs-test | |||
|
|
|||
| compile_missing_packs: true | |||
|
|
|||
| compiler_cache_path: tmp/.webpacker-checksum | |||
There was a problem hiding this comment.
Doesn't need to be configurable, IMO. How about tmp/webpacker/checksum? Then any future temp files can share that dir.
lib/install/config/webpacker.yml
Outdated
| compiler_tracked_paths: | ||
| - app/javascript/**/* | ||
| - yarn.lock | ||
| - package.json |
There was a problem hiding this comment.
Perhaps make these the defaults internally and add an API for watching additional paths. Like Spring does: https://github.com/rails/spring#watching-files-and-directories
There was a problem hiding this comment.
That would be nice. Will push something later 👍
lib/webpacker/compiler.rb
Outdated
| compile_task.invoke | ||
| compile_task.reenable | ||
| end | ||
|
|
||
| private | ||
| def source_checksum |
There was a problem hiding this comment.
Not sure if checksum is the best term since it's not computing a hash. Maybe something more explicit?
There was a problem hiding this comment.
Yeah me too. May be source_timestamp?
|
@javan Pushed some updates. Please review when you get a chance |
lib/install/config/webpacker.yml
Outdated
| @@ -4,7 +4,7 @@ default: &default | |||
| source_path: app/javascript | |||
| source_entry_path: packs | |||
| public_output_path: packs | |||
| compile_missing_packs: true | |||
| compile_missing_packs: false | |||
There was a problem hiding this comment.
Should we rename this to just compile? The "missing" part no longer applies.
There was a problem hiding this comment.
@javan Sure, that would make more sense or may be test_compiler_enabled: for clarity- I was looking at this for 5 minutes and finally had to refer to PR to understand what this does 👍
There was a problem hiding this comment.
I don't see this is a test env feature. It's quite useful in dev mode too.
There was a problem hiding this comment.
That's true - much like webpack watcher (but slow) 👍
lib/webpacker/compiler.rb
Outdated
| @@ -3,12 +3,48 @@ | |||
| module Webpacker::Compiler | |||
| extend self | |||
|
|
|||
| # Default paths watched for changes | |||
| DEFAULT_WATCHED_PATHS = ["app/javascript/**/*", "yarn.lock", "package.json"].freeze | |||
There was a problem hiding this comment.
Watch config/webpacker.yml and config/webpacker/**/* too?
There was a problem hiding this comment.
Oh yes - may be we can just watch - config/webpack/**/*
lib/webpacker/compiler.rb
Outdated
| # Additional paths that test compiler needs to watch | ||
| # Webpacker::Compiler.watched_paths << 'bower_components' | ||
| mattr_accessor :watched_paths | ||
| @@watched_paths = [] |
There was a problem hiding this comment.
Can set default values with a block: mattr_accessor(:watched_paths) { [] }
Update changelog Fix test Update webpacker Fix wordings Change method name for clarity Update readme Remove webpack-dev-server bit for now Update toc Add tests for new configuration Move configuration to compiler class and make it configurable programmatically Fix readme Only run compiler in test env Add compiler test Change method name Remove Rails.root Use stub Rename to compile and update syntax Update changelog Revert escaping
Fixes: #468
Discussion Ref: #360
Make test compilation cacheable and configurable so the lazy compilation only triggers if files are changed under tracked paths. Following paths are watched by default -
To add more paths:
cc // @richseviora @stevehanson @raldred @kernow