Add a test helper #341
Closed
Add a test helper #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Add a delete method to manifest Remove delete for now Remove exist? for now and document in readme Fix wording Fix sentence Add a checksum so it doesn't compile unless changed Add namespace Make rubocop happy
javan
reviewed
May 8, 2017
| end | ||
|
|
||
| def compile_webpack_assets | ||
| Rails.cache.fetch(["webpacker", "manifest", checksum]) do |
There was a problem hiding this comment.
This cache key will only be invalidated when your files change, right? What if, for example, you bump the version of a dependency in package.json? I think it'd be best to avoid caching unless we can use the same digests provided by webpack.
There was a problem hiding this comment.
@javan Yepp that's right. Good point 👍 Perhaps we should watch package.json and yarn.lock for changes too? The compile task slows down the tests so it's best to cache because we won't be able to get new digests from webpack until it's compiled (which is same thing as re-compiling) unless I am missing something??
There was a problem hiding this comment.
Added yarn.lock and package.json to watch list
|
Closing in favor of #360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhh As we discussed the other day this addresses compiling assets in tests based on @javan's idea. Also removed the rake task enhancements because it's compiling twice and could also lead to confusion, this way it's more clear. What do you think?
We will need to merge the reload PR #292 first because that will make sure that manifest change has been picked up whenever it changes.