[BUG] Add resolved paths to app-code babel compile #1946
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we split the
node_module
compiling from the app code compiling, we left outresolved_paths
. I first noticed this after I upgraded tov4.0.0.rc.3
fromv4.0.0.rc.2
.This commit has now created the whitelist of
node_module
compiled code, which left myresolved_paths
out of the loop (neither compiled by accident by the old node_module config, nor compiled by the babel config because it only looks at thesource_path
)For people providing
resolved_paths != []
I realize not every project is using
resolved_paths
but without this you get very confusing errors if yoursource_path
code is depending onresolved_path
code. I think whatever performance penalty you get from this should be expected given it's clearly stated thatresolved_paths
are not-ideal elsewhere.It's hard to imagine this would be unexpected/unwanted for people specifying
resolved_paths
because it was probably happening in Webpacker 3.x anywayFor people providing
resolved_paths === []
For people not using
resolved_paths
this will have no effect.