Exclude Rails 4.2 + ruby-head build #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 4.2 is using `BigDecimal.new`. But `BigDecimal.new` was removed. Ref: ruby/bigdecimal@d73eca2 This causes the build of Rails 4.2 + ruby-head to fail. https://travis-ci.org/rails/webpacker/jobs/462579174#L1292 Let's exclude this in order to keep the build state clean.
|
Yep, lets done that already in #1823 but let's merge this one 🙏 |
|
I decided to revert removing BigDecimal.new for the next version of bigdecimal. |
koic
added a commit
to koic/webpacker
that referenced
this pull request
Dec 25, 2018
Follow up of rails#1825 (comment). And this reverts commit c48cf46. ### Summary This PR restores Rails 4.2 + ruby-head (2.6) build. Ruby 2.6.0 has been released. https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/ `BigDecimal.new` has been replaced with deprecation rather than deletion. ```console % ruby -rbigdecimal -ve 'BigDecimal.new(42)' ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin17] -e:1: warning: BigDecimal.new is deprecated; use BigDecimal() method instead. ```
gauravtiwari
pushed a commit
that referenced
this pull request
Dec 25, 2018
Follow up of #1825 (comment). And this reverts commit c48cf46. ### Summary This PR restores Rails 4.2 + ruby-head (2.6) build. Ruby 2.6.0 has been released. https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/ `BigDecimal.new` has been replaced with deprecation rather than deletion. ```console % ruby -rbigdecimal -ve 'BigDecimal.new(42)' ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin17] -e:1: warning: BigDecimal.new is deprecated; use BigDecimal() method instead. ```
sue445
added a commit
to sue445/komachi_heartbeat
that referenced
this pull request
Dec 30, 2018
KingTiger001
added a commit
to KingTiger001/Rails-web-pack-project
that referenced
this pull request
Jan 15, 2023
Follow up of rails/webpacker#1825 (comment). And this reverts commit c48cf46c667830aac9df832c7afd97591fca580e. ### Summary This PR restores Rails 4.2 + ruby-head (2.6) build. Ruby 2.6.0 has been released. https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/ `BigDecimal.new` has been replaced with deprecation rather than deletion. ```console % ruby -rbigdecimal -ve 'BigDecimal.new(42)' ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin17] -e:1: warning: BigDecimal.new is deprecated; use BigDecimal() method instead. ```
smartech7
pushed a commit
to smartech7/ruby-webpacker
that referenced
this pull request
Aug 4, 2023
Follow up of rails/webpacker#1825 (comment). And this reverts commit c48cf46c667830aac9df832c7afd97591fca580e. ### Summary This PR restores Rails 4.2 + ruby-head (2.6) build. Ruby 2.6.0 has been released. https://www.ruby-lang.org/en/news/2018/12/25/ruby-2-6-0-released/ `BigDecimal.new` has been replaced with deprecation rather than deletion. ```console % ruby -rbigdecimal -ve 'BigDecimal.new(42)' ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin17] -e:1: warning: BigDecimal.new is deprecated; use BigDecimal() method instead. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 4.2 is using
BigDecimal.new. ButBigDecimal.newwas removed.Ref: ruby/bigdecimal@d73eca2
This causes the build of Rails 4.2 + ruby-head to fail.
https://travis-ci.org/rails/webpacker/jobs/462579174#L1292
Let's exclude this in order to keep the build state clean.