Rename Authentication template files #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to [#53098][] The corresponding commit in `rails/rails` nested the template files (including the view templates) under an `app/` directory. This commit makes a corresponding change, nesting the `views/` templates under `app/views/`. [#53098]: rails/rails#53098 (comment) Co-authored-by: Jerome Dalbert <[email protected]>
4 tasks
|
@guilleiguaran What's your plan for making sure this is backwards compatible with Rails 8 beta1? Currently this change breaks with Rails 8 beta1, which means I can't cut a release of this gem until there's a beta2 with the above change. |
|
@flavorjones we can revert this and cut the release of the gem and then re-apply to ensure this is in place for the beta2 compatible release. |
|
I'll figure it out. |
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rails/rails#53103
Follow-up to rails/rails#53098
The corresponding commit in
rails/railsnested the template files (including the view templates) under anapp/directory.This commit makes a corresponding change, nesting the
views/templates underapp/views/.