Allow no compression for all environments

[jsilvestri]

Change 339529f made it so that one can no longer turn off compression in any environment except development. This is both a bit confusing (e.g. you set it to nil and expect it to work, but it doesn't!) and difficult if you really want to turn compression off. This change allows the statement config.assets.css_compressor = nil to function in all environments.

[byroot]

👍

[rafaelfranca]

Why just for development. If we are going to make it configurable better to do for all environment. Mind to change that?

[jsilvestri]

@rafaelfranca I'm not quite sure I follow you. My change is to make it so that one can set app.config.assets.css_compressor = nil in all environments. The former code only allows you to do so on development. The code might look a little cleaner this way -- is this what you were thinking?

if Rails.env.development?
  # For development, default to an expanded output instead of the sass default of :nested
  app.config.sass.style ||= :expanded
else
  # Default to compress css in non-development environments
  # while still allowing it to be overridden to nil
  app.config.assets.css_compressor = :sass unless app.config.assets.has_key?(:css_compressor)
end

[jsilvestri]

@rafaelfranca / @byroot any more thoughts?

[byroot]

Yeah sorry @jsilvestri. Totally looks good to me!

[jsilvestri]

@byroot I don't have merge privileges -- are you able to merge?

[byroot]

@rafaelfranca will merge if it looks good to him too. Don't worry :)

[rafaelfranca]

Thank you!