Add CONTRIBUTING.md #43
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
This URL may confuse people? Maybe Go to your fork in GitHub?
There was a problem hiding this comment.
Prefer this URL - makes it easy so people just slide their GH username in where it says contributor. Not true for all projects, but the name of this project (Rails HTML Santizers) doesn't match the GH project url slug (rails-html-sanitizer). Also, worth updating all of the PRs for this?
There was a problem hiding this comment.
Also, worth updating all of the PRs for this?
Yeah, it is not.
|
Awesome! I have one minor comment after that we can merge this one. |
|
❤️ 💚 💙 💛 💜 |
3 participants
cc @rafaelfranca