Add upgrade guide for propshaft #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenogazzola
changed the title
|
The rough version of the guide is ready. It contains every step I had to take to migrate my own production app. Now it needs someone with a better grasp of the english language to clean it up and other developers to attempt the migration and point out what's missing or confusing. |
t27duck
reviewed
Dec 2, 2021
dixpac
reviewed
Dec 4, 2021
brenogazzola
force-pushed
the
upgrade-guide
branch
from
de650d4 to
0bcabf6
Compare
|
Revised the guide a bit. Switched passive voice to active voice, added a couple missing steps, simplified some explanations. |
dixpac
reviewed
Dec 6, 2021
SebouChu
reviewed
Dec 9, 2021
brenogazzola
force-pushed
the
upgrade-guide
branch
from
9024a21 to
ebff869
Compare
coding-chimp
reviewed
Jan 3, 2022
brenogazzola
force-pushed
the
upgrade-guide
branch
from
ebff869 to
3db0b60
Compare
sedubois
added a commit
to sedubois/propshaft
that referenced
this pull request
Mar 2, 2022
I suppose the upgrade guide introduced in rails#35 should instruct to remove Sprockets from the Gemfile? Section 3 point 4 instructs to remove `app/assets/config/manifest.js`, which yields `Sprockets::Railtie::ManifestNeededError` when Sprockets is still present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
webpackertojsbundling-railssass-railstocssbundling-railssprocketstopropshaft