Remove railties runtime dependency#239
Merged
Merged
Conversation
andheiberg
reviewed
Jun 12, 2025
andheiberg
left a comment
andheiberg
left a comment
There was a problem hiding this comment.
I can confirm we have a real use-case for using Propshaft outside of Rails and that this would make that possible.
zcei
force-pushed
the
remove-railties-dep
branch
from
c1cb288 to
94a95aa
Compare
We don't need to go back to the Rails application to access the cache sweeper we already have the assembly instance in the server class.
So the LoadPath class don't need to go back to the Rails application to access the file watcher.
rafaelfranca
force-pushed
the
remove-railties-dep
branch
from
5ac27c8 to
8ea1b4f
Compare
rafaelfranca
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library technically has no dependency on
railtiesto function.Only if the environment we're in defines
Railtie(Ruby on Rails) we want to load Rails specific behavior, but at this point we can rely on the gem already being loaded.Making this change enables us to make it actually work in a standalone Rack environment, without implicitly changing the behavior of other gems that try to load their own railties because of the dependency being loaded.