Server should also sweep cache#232
Merged
Merged
Conversation
brenogazzola
force-pushed
the
server-should-sweep
branch
from
60eb231 to
1deff49
Compare
brenogazzola
force-pushed
the
server-should-sweep
branch
from
1deff49 to
d9bf348
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #228
Closes #110
Finally figured out the problem. With puma on cluster mode, a page request might be served by worker 1, which will cause a sweep if there were updates, but an asset served by the server on worker 2... which has not swept the cache yet. And since the request is hitting the
Serverinstance, instead of a controller it will not cause a sweep.