Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve options with stylesheet_link_tag :all #177

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

kevinmcconnell
Copy link
Contributor

Ensure that we don't lose any options passed to stylesheet_link_tag when using the :all option.

Previously the kwargs were being discarded, which breaks common use cases like:

stylesheet_link_tag :all, "data-turbo-track": "reload"

/cc @dhh

Ensure that we don't lose any options passed to `stylesheet_link_tag`
when using the `:all` option. Previously the options were being
discarded.
@kevinmcconnell kevinmcconnell force-pushed the preserve_stylesheet_link_tag_options branch from 066d6d8 to 59d1dc3 Compare January 10, 2024 09:15
@dhh dhh merged commit e7cdbcd into rails:main Jan 10, 2024
4 checks passed
dhh pushed a commit that referenced this pull request May 15, 2024
Ensure that we don't lose any options passed to `stylesheet_link_tag`
when using the `:all` option. Previously the options were being
discarded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants