Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting basic auth config by hand #223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morgoth
Copy link
Member

@morgoth morgoth commented Dec 5, 2024

No description provided.

@rosa
Copy link
Member

rosa commented Dec 5, 2024

Hi @morgoth, thanks for this! But this was not supported on purpose, as a deterrent to avoid people setting secret as their password, forcing having to use Rails credentials and providing an easy way to set those via a command.

@morgoth
Copy link
Member Author

morgoth commented Dec 5, 2024

Not being able to set it by hand as all other configs would make people confuse when they try it (as me ;-).
Also I can imagine people setting secrets via env variable, which for them it won't be possible to use this feature.

@rosa
Copy link
Member

rosa commented Dec 5, 2024

I think the README explains it, in case someone is confused 🤔 I'll wait to see if this actually becomes a problem before changing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants