Go back to relative times and a better locale management #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
force-pushed
the
back-to-relative-times
branch
from
1edf500 to
1d1877c
Compare
The absolute times are quite hard to use, and we can force the locale for these instead.
One of them is basically the same as another one.
Without interferring with the host application's I18n configuration. I18n's available_locales unfortunately is not thread-safe so we can't just change that, but I18n.config is thread-safe [1], so we can use our own there, that just relies on all I18n defaults except for available locales. [1] https://github.com/ruby-i18n/i18n/blob/3b65f6548245411bc9802f5a547954d370b57821/lib/i18n.rb#L56-L64
rosa
force-pushed
the
back-to-relative-times
branch
from
1d1877c to
b449afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some attempts at handling this (#137, #156 and #184), I think this is the definitive. The locale is hardcoded to
:en, but for the cases where the host application might not have:enavailable, we just use a custom config for I18n. I18n'savailable_localesunfortunately is not thread-safe, so we can't just change that in anaround_action, butI18n.configis thread-safe, so we can use our own there, that just relies on all I18n defaults except for available locales.