Add Retries field into views #204
Open
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
reviewed
Nov 13, 2024
app/views/mission_control/jobs/jobs/_general_information.html.erb
Outdated
Show resolved
Hide resolved
|
@rosa When you have time to take a look at this PR |
rosa
reviewed
Nov 30, 2024
lib/active_job/job_proxy.rb
Outdated
| @@ -20,6 +20,10 @@ def serialize | |||
| end | |||
| end | |||
|
|
|||
| def retries | |||
| self.arguments.first["executions"] || 0 | |||
There was a problem hiding this comment.
Hmmm... I have two questions about this... first, do we need self? Second, does this work in general? 🤔 This extends ActiveJob::Base, which means arguments are the deserialized job arguments (which probably won't be deserialized here yet, because they're lazily deserialized when they're needed).
There was a problem hiding this comment.
in fact the self was not necessary.
And yes, it works, at least it is working on the screens where I applied it lol
|
Sorry @MacLove13, I hadn't realised it was ready for review again 😳 |
This was referenced Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Retries to Index at failed jobs and show job.