Use Thor's apply instead of prerequisite tasks
#183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `javascript:install:shared` and `javascript:install:node_shared` tasks serve only as prerequisites for the other installer tasks; they should not be run on their own (nor listed with `rake --tasks`). By replacing those tasks with corresponding calls to Thor's `apply` method, we avoid the overhead of running `bin/rails app:template` (and `bundle install`) multiple times. This commit also renames `install_node.rb` to `install_procfile.rb` since it is concerned with generating a `Procfile.dev` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
javascript:install:sharedandjavascript:install:node_sharedtasks serve only as prerequisites for the other installer tasks; they should not be run on their own (nor listed withrake --tasks). By replacing those tasks with corresponding calls to Thor'sapplymethod, we avoid the overhead of runningbin/rails app:template(andbundle install) multiple times.This commit also renames
install_node.rbtoinstall_procfile.rbsince it is concerned with generating aProcfile.devfile.As a point of comparison, running the tests from #182 without this PR:
And running them with this PR: