-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Return early from collection partial rendering if blank. #560
Merged
+36
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derricklannaman
referenced
this pull request
in powerhome/power-web-development-interview
Sep 24, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jbuilder](https://github.com/rails/jbuilder) ([changelog](https://github.com/rails/jbuilder/releases/tag/v2.13.0)) | `2.12.0` -> `2.13.0` | [![age](https://developer.mend.io/api/mc/badges/age/rubygems/jbuilder/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/jbuilder/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/jbuilder/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/jbuilder/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>rails/jbuilder (jbuilder)</summary> ### [`v2.13.0`](https://github.com/rails/jbuilder/releases/tag/v2.13.0) [Compare Source](https://github.com/rails/jbuilder/compare/v2.12.0...v2.13.0) #### What's Changed - Redirect to `@record` or path in controller generator by [@​jeromedalbert](https://github.com/jeromedalbert) in [https://github.com/rails/jbuilder/pull/569](https://github.com/rails/jbuilder/pull/569) - Return early from collection partial rendering if blank by [@​tylerjc](https://github.com/tylerjc) in [https://github.com/rails/jbuilder/pull/560](https://github.com/rails/jbuilder/pull/560) - Add missing ':see_other' status code in generated destroy controller method by [@​ldeld](https://github.com/ldeld) in [https://github.com/rails/jbuilder/pull/538](https://github.com/rails/jbuilder/pull/538) - Remove OpenStruct references from Jbuilder by [@​mtsmfm](https://github.com/mtsmfm) in [https://github.com/rails/jbuilder/pull/567](https://github.com/rails/jbuilder/pull/567) - Use new `params.expect` syntax instead of `params.require` by [@​jeromedalbert](https://github.com/jeromedalbert) in [https://github.com/rails/jbuilder/pull/573](https://github.com/rails/jbuilder/pull/573) #### New Contributors - [@​jeromedalbert](https://github.com/jeromedalbert) made their first contribution in [https://github.com/rails/jbuilder/pull/570](https://github.com/rails/jbuilder/pull/570) - [@​tylerjc](https://github.com/tylerjc) made their first contribution in [https://github.com/rails/jbuilder/pull/560](https://github.com/rails/jbuilder/pull/560) - [@​ldeld](https://github.com/ldeld) made their first contribution in [https://github.com/rails/jbuilder/pull/538](https://github.com/rails/jbuilder/pull/538) - [@​mtsmfm](https://github.com/mtsmfm) made their first contribution in [https://github.com/rails/jbuilder/pull/567](https://github.com/rails/jbuilder/pull/567) **Full Changelog**: rails/jbuilder@v2.12.0...v2.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/powerhome/power-web-development-interview). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was messing around with making a project's Jbuilder renders more efficient the other day.
I noticed that even empty collections trigger partial renders and take milliseconds for each, although they end up just returning
[]
. For the examples below (pulled from the README):Originally, I had written a little helper method in our project to optionally include the
{ partial:, as: }
hash to thejson.comments(@post.comments)
call, but that seemed cumbersome to include everywhere and I wondered why this wasn't somehow handled inJbuilder
code.I just started messing around locally and found that this seems to take care of it, but figured I'd open a discussion and see what others think, since I'm extremely knew to Jbuilder and could be missing something obvious.
Screenshots (Console Output Differences)