Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich_text, attachment, and attachments fields support #459

Merged

Conversation

excid3
Copy link
Contributor

@excid3 excid3 commented Apr 5, 2019

I just added support for generating models with rich_text, attachment and attachments fields for ActionText and ActiveStorage to Rails 6 recently.

This updates jbuilder's scaffold generator to also support these fields and retains the old functionality for older Rails versions.

@excid3 excid3 force-pushed the add-rich_text-and-attachment-fields-support branch from dee2b0f to 952f675 Compare April 5, 2019 17:27
@excid3
Copy link
Contributor Author

excid3 commented May 13, 2019

@rafaelfranca wanted to bump this. Would you consider merging this one since Rails 6 already has these generator fields in rails/rails#35805?

Jbuilder overrides the generators so they would appear to not work in a new Rails 6 app until jbuilder is also updated. Thanks!

@dpaola2
Copy link

dpaola2 commented Mar 29, 2020

Voicing my support for this functionality

@dhh dhh merged commit cc046c4 into rails:master Jan 22, 2021
@excid3 excid3 deleted the add-rich_text-and-attachment-fields-support branch January 22, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants