Use padding: false option over gsub #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's up?
I used the
#to_param
for my GIDs and it's awesome. Was reading the code and noticed a small improvement opportunity.Since Ruby
>= 2.3.0
,Base64.urlsafe_encode64
acceptspadding: false
to exclude padding.Base64.urlsafe_decode64
also works with strings with or without padding.This PR removes the custom gsub in favor of using
padding: false
The caveat is that this method will break for Ruby
< 2.3