Skip to content

Commit

Permalink
Merge pull request #84 from udzura/prefer-to-use-node
Browse files Browse the repository at this point in the history 
Search `node` binary first even when `nodejs` exists
  • Loading branch information
@guilleiguaran
guilleiguaran authored Jan 21, 2019
2 parents 7dd2a79 + cf0ffff commit f6dc08c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/execjs/runtimes.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module Runtimes

Node = ExternalRuntime.new(
name: "Node.js (V8)",
command: ["nodejs", "node"],
command: ["node", "nodejs"],
runner_path: ExecJS.root + "/support/node_runner.js",
encoding: 'UTF-8'
)
Expand Down

2 comments on commit f6dc08c

@schmijos
Copy link

@schmijos schmijos commented on f6dc08c Sep 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is especially useful if you use NVM to select your node version.

image

@TonGarcia
Copy link

@TonGarcia TonGarcia commented on f6dc08c Nov 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is still crashed for me in ubuntu, I is still using nodejs instead node, how can I fix it?
Rails version: Rails 6.0.3.4
it is working on Mac, but not on WSL (ubuntu on windows)

FIXED: apt-get purge nodejs so only node was a set command

Please sign in to comment.