Minor portability improvements to ./bin/dev #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
env: can't execute 'bash': No such file or directory use sh as lowest common denominator
|
Hi @defeated, |
stevenharman
added a commit
to stevenharman/jsbundling-rails
that referenced
this pull request
Aug 26, 2022
Some distros don't ship with bash, but will have sh. see also: rails/cssbundling-rails#98
This was referenced Nov 4, 2022
dhh
pushed a commit
to rails/jsbundling-rails
that referenced
this pull request
Dec 14, 2022
* exec foreman to replace current process Use `exec` to invoke `foreman` to make sure `bin/dev` is replaced by the `foreman` process. This ensures that `foreman` gets `bin/dev`'s pid (so it's cleaned up properly) and that interrupts and signals (like `ctrl+c`) are handled correctly by `foreman` (to shut down child processes). * Use sh as least common denominator shell Some distros don't ship with bash, but will have sh. see also: rails/cssbundling-rails#98
titan2gman
added a commit
to titan2gman/jsbundling-rails
that referenced
this pull request
Dec 27, 2022
* exec foreman to replace current process Use `exec` to invoke `foreman` to make sure `bin/dev` is replaced by the `foreman` process. This ensures that `foreman` gets `bin/dev`'s pid (so it's cleaned up properly) and that interrupts and signals (like `ctrl+c`) are handled correctly by `foreman` (to shut down child processes). * Use sh as least common denominator shell Some distros don't ship with bash, but will have sh. see also: rails/cssbundling-rails#98
smartech7
pushed a commit
to smartech7/ruby-js-bundling
that referenced
this pull request
Aug 4, 2023
* exec foreman to replace current process Use `exec` to invoke `foreman` to make sure `bin/dev` is replaced by the `foreman` process. This ensures that `foreman` gets `bin/dev`'s pid (so it's cleaned up properly) and that interrupts and signals (like `ctrl+c`) are handled correctly by `foreman` (to shut down child processes). * Use sh as least common denominator shell Some distros don't ship with bash, but will have sh. see also: rails/cssbundling-rails#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple issues we ran into, using small alpine ruby image under docker, developing locally with docker compose:
use
execto invokeforeman. This ensures thedevscript is replaced by theforemanprocess and signals/interrupts like ctrl+c are handled correctly. Without this, the childforemanprocesses are not stopped gracefully and the PID file not cleaned up.replace
bashwithsh. Alpine Linux (for example) ships withash(notbash) but includessh, so this seems like a reasonable choice as "lowest common denominator"Gist of minimal test case:
https://gist.github.com/defeated/5d1b7469d5fedb6d6b242f141c68c895