Associations: Support :primary_key and :foreign_key
#467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem --- Some `has_many` and `has_one` associations provided by APIs are "joined" by properties other than their `id` (or an overridden `primary_key`). The proposal --- By default, continue to infer the `:foreign_key` as `self.class.element_name + "_id"` and its `:primary_key` from the value of its primary key (returned by the `id` method). When necessary, `has_many` declarations can declare `:primary_key` and `:foreign_key` options in the same style as [Active Record's `has_many` associations][has_many]. [has_many]: https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Some
has_manyandhas_oneassociations provided by APIs are "joined" by properties other than theirid(or an overriddenprimary_key).The proposal
By default, continue to infer the
:foreign_keyasself.class.element_name + "_id"and its:primary_keyfrom the value of its primary key (returned by theidmethod).When necessary,
has_manydeclarations can declare:primary_keyand:foreign_keyoptions in the same style as Active Record'shas_manyassociations.