Mix ActiveModel::AttributeMethods into ActiveResource::Base
#465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem --- The current attribute reading and writing implementation relies upon `#method_missing` and `#respond_to_missing?` for access. When attributes are defined by a schema, it's possible to define methods for them at "declaration time", rather than implementing access entirely through method missing reflection. The solution --- Mix [ActiveModel::AttributeMethods][] into `ActiveResource::Base`, then hook into `schema` assignment. When assigning attributes, invoke [define_attribute_methods][]. When the schema is reset to be `nil`, invoke [undefine_attribute_methods][]. Similarly, invoke `define_attribute_methods` on an instance's `singleton_class` when writing to an attribute through the `#load` method. Subsequent reads and writes will rely on the ephemeral method (which will invoke `#write_attribute` and `#read_attribute`) rather than `#method_missing`. [ActiveModel::AttributeMethods]: https://api.rubyonrails.org/classes/ActiveModel/AttributeMethods.html [define_attribute_methods]: https://api.rubyonrails.org/classes/ActiveModel/AttributeMethods/ClassMethods.html#method-i-define_attribute_methods [undefine_attribute_methods]: https://edgeapi.rubyonrails.org/classes/ActiveModel/AttributeMethods/ClassMethods.html#method-i-undefine_attribute_methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The current attribute reading and writing implementation relies upon
#method_missingand#respond_to_missing?for access.When attributes are defined by a schema, it's possible to define methods for them at "declaration time", rather than implementing access entirely through method missing reflection.
The solution
Mix ActiveModel::AttributeMethods into
ActiveResource::Base, then hook intoschemaassignment. When assigning attributes, invoke define_attribute_methods. When the schema is reset to benil, invoke undefine_attribute_methods.Similarly, invoke
define_attribute_methodson an instance'ssingleton_classwhen writing to an attribute through the#loadmethod. Subsequent reads and writes will rely on the ephemeral method (which will invoke#write_attributeand#read_attribute) rather than#method_missing.