add to_param for correct URL generation #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurko
added a commit
that referenced
this pull request
Jan 30, 2015
add to_param for correct URL generation
|
FWIW, @carlesjove I removed this in #981 because I couldn't tell where it was used :) |
|
It was used in another PR that I made, which wasn't merged yet. If that PR
is going to be merged I'll see if I can do without it, or start a
conversation on the issue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think that this needs tests, but I can write them if necessary. Just make sure that the correct URL is generated when using Rails'
url_helpersin tests.