Adds support for meta attribute #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guilleiguaran tested and working 😁 |
|
|
||
| def include_meta(json) | ||
| puts "meta: #{meta.inspect}" if $debug | ||
| puts "root: #{root.inspect}" if $debug |
Currently, 0.10.0.pre doesn't support `meta` option in `render`. This way, there's no way to support features such as pagination. `0.9` had this feature in place. This adds support for it, as well as fixes small things in README.md. This won't support `meta` in array responses because arrays don't have keys, obviously. Also, the response should have a `root` key, otherwise no `meta` will be included. In some cases, for example using JsonApi, ArraySerializer will result in a response with a `root`. In that case, `meta` will be included.
guilleiguaran
added a commit
that referenced
this pull request
Jan 5, 2015
Adds support for meta attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, 0.10.0.pre doesn't support
metaoption inrender. Thisway, there's no way to support features such as pagination.
0.9hadthis feature in place.
This adds support for it, as well as fixes small things in README.md.
This won't support
metain array responses because arrays don't havekeys, obviously. Also, the response should have a
rootkey, otherwiseno
metawill be included.In some cases, for example using JsonApi, ArraySerializer will result in
a response with a
root. In that case,metawill be included.