Bugfix: include nested has_many associations #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, doing `include: author.bio` would work correctly, but not for has_many associations such as `include: author.roles`. This fixes it. The problem was basically that we were not handling arrays for has_many linked, as happens for ArraySerializers.
|
Would love some +1's here so I don't feel bad merging my own PR. /cc @ggordon @guilleiguaran |
|
Looks good in my opinion 😄 |
|
+1 |
1 similar comment
|
👍 |
kurko
added a commit
that referenced
this pull request
Nov 12, 2014
…as-many Bugfix: include nested has_many associations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, doing
include: author.biowould work correctly, but not forhas_many associations such as
include: author.roles. This fixes it.The problem was basically that we were not handling arrays for has_many linked,
as happens for ArraySerializers.