Slim down bundled gem by excluding test files and docs #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose I'm not opposed. How big is the difference? |
|
Bundled gem goes from 436KB to 60KB |
|
wow, that's pretty big |
|
is there any update on this? I like the findings very much and would love to see 0.10.10+ versions benefit from this PR |
|
hi @greysteil can you please rebase the PR against latest |
|
Rebased! Looks like test setup is failing but unrelated. |
|
thanks @greysteil. can you please add an entry in the changelog too under the features tag? |
|
For sure - done! |
|
great optimization PR! @greysteil thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Slim down the bundled gem from 436KB to 60KB
Changes
test_filesfrom gemspec since it's deprecated (Documentation about 'test_files' is confusing rubygems/guides#90)libinfilesin gemspec, since they're all that's required to build the gemAdditional helpful information
This is the approach taken by rails.