add test and fix for collection not supporting namespaces #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NullVoxPopuli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bf4 to be a potential reviewer. |
Member
|
@NullVoxPopuli looks like we opened a PR at the same time ahah |
Contributor
Author
|
lets use yours, as I think I like your explicit passing of the namespace better than passing all the options through. |
NullVoxPopuli
deleted the
bugfix/namespace-serializer-lookup-on-collections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow collection serializers to utilize the namespace option
Changes
Pass options to collection serializer's call to serializer_for
Caveats
Unknown
Related GitHub issues
#1757 (comment)
Additional helpful information
Found by @groyoh